Fix bug where a model with empty weights fails to load #7868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
fengwuyao
approved these changes
Jul 28, 2023
pyu10055
approved these changes
Jul 28, 2023
|
Just merged in latest master. Is there something I need to do prior to merge, or is this in y'all's hands now? |
Neilblaze
approved these changes
Aug 8, 2023
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft at addressing #7865.
This slightly refactors the
Container.loadWeightsfunction by pulling the "is this model a keras model" into a standalone function. That function will first assert that the model has non-empty weights before checking the first weight's name (which is subsequently used to determine keras-ness or not).This also adds a unit test in
model_save_test.tsenforcing that a model with empty weights can still be loaded.