webgpu: Enable importExternalTexture #7976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues related to importExternalTexture were fixed in Chrome, so that we may enable this feature by default again. Note that its Linux implementation still has problem, and WebGPU support on Linux hasn't been officially released yet. Bug tensorflow#7972
qjia7
reviewed
Sep 25, 2023
| // browser impl | ||
| const importVideo = | ||
| false && env().getBool('WEBGPU_IMPORT_EXTERNAL_TEXTURE') && isVideo; | ||
| env().getBool('WEBGPU_IMPORT_EXTERNAL_TEXTURE') && isVideo; |
Contributor
There was a problem hiding this comment.
I remember we have a related test case. Do you need to change the corresponding test?
Author
There was a problem hiding this comment.
Yes, I just added the fix to the test case. Thanks!
qjia7
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues related to importExternalTexture were fixed in Chrome, so that we may enable this feature by default again.
Note that its Linux implementation still has problem, and WebGPU support on Linux hasn't been officially released yet.
Bug #7972
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.