Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgpu: Enable importExternalTexture #7976

Merged
merged 2 commits into from
Sep 25, 2023
Merged

webgpu: Enable importExternalTexture #7976

merged 2 commits into from
Sep 25, 2023

Conversation

gyagp
Copy link

@gyagp gyagp commented Sep 25, 2023

Issues related to importExternalTexture were fixed in Chrome, so that we may enable this feature by default again.
Note that its Linux implementation still has problem, and WebGPU support on Linux hasn't been officially released yet.
Bug #7972

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

Issues related to importExternalTexture were fixed in Chrome, so that we
may enable this feature by default again.
Note that its Linux implementation still has problem, and WebGPU support
on Linux hasn't been officially released yet.
Bug tensorflow#7972
const importVideo =
false && env().getBool('WEBGPU_IMPORT_EXTERNAL_TEXTURE') && isVideo;
env().getBool('WEBGPU_IMPORT_EXTERNAL_TEXTURE') && isVideo;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we have a related test case. Do you need to change the corresponding test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just added the fix to the test case. Thanks!

Copy link
Collaborator

@Linchenn Linchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Yang!

@pyu10055 pyu10055 merged commit a7bec12 into tensorflow:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants