-
Notifications
You must be signed in to change notification settings - Fork 941
Reenable recording_micro_allocator_test #3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ced52c4
to
116e513
Compare
116e513
to
1869e8d
Compare
1869e8d
to
ffa9021
Compare
ffa9021
to
f360862
Compare
f360862
to
272ba2a
Compare
272ba2a
to
015ccd1
Compare
@ddavis-2015 I'd like to merge this separately from #3197 to ensure the two changes are atomic. I've ported over the relevant fixes from your PR to address the issue here. Thanks for your work on that! |
015ccd1
to
9a1fb92
Compare
As described above, it doesn't seem to need to regenerate a test model. So I removed that part from the PR. |
@veblush |
A recent QEMU upgrade appears to expose an underlying unaligned memory access issue on Cortex-M3. This is causing crashes (uncaught target signal 7 (Bus error)) in two tests,
TestRecordsPersistentTfLiteTensorData
andTestRecordsPersistentTfLiteTensorQuantizationData
, which were temporarily disabled in PR #3206.The crash occurs when accessing the test model's Flatbuffer memory, as shown by the following callstack:
My hypothesis was that the pre-generated test model file has an alignment defect but it turned out that just adding alignas(16) to the model variable was enough to fix the tests.
BUG=TestFix