Pin down feast dependency #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 Instructions: Approve using |
|
/merge |
Closed
|
/lgtm |
|
Merged with approvals from codesue - thanks for the contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current last version may not resolve feast dep due to feast>=0.23 upgrading their numpy version which does not resolve on py 3.7.
This is an attempt to fix it before we drop py 3.7.
Updated minimal version supported which grants a new release but it was needed as I couldn't find a way to make it work with the existing versions without having to pin the entirety of Google repos.
Also had to upgrade isort in pre-commit due to an issue in the dependency as seen in home-assistant/core#86892