Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use requirements.txt when specifying TFX dependency with Beam. #1699

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Do not use requirements.txt when specifying TFX dependency with Beam. #1699

merged 1 commit into from
Apr 29, 2020

Conversation

tfx-copybara
Copy link
Collaborator

Do not use requirements.txt when specifying TFX dependency with Beam.

Needed because of upstream https://issues.apache.org/jira/browse/BEAM-4032, as the portability stager is now used for Dataflow jobs as well.

@tfx-copybara tfx-copybara force-pushed the test_308933408 branch 4 times, most recently from a9370b4 to 8564127 Compare April 29, 2020 05:54
@tfx-copybara
Do not use requirements.txt when specifying TFX dependency with Beam.
ddb01c0 
Needed because of upstream https://issues.apache.org/jira/browse/BEAM-4032, as the portability stager is now used for Dataflow jobs as well.

PiperOrigin-RevId: 308968052
@tfx-copybara tfx-copybara merged commit ddb01c0 into master Apr 29, 2020
@tfx-copybara tfx-copybara deleted the test_308933408 branch April 29, 2020 06:26
@Ark-kun Ark-kun mentioned this pull request Apr 29, 2020
Closed
copybara-service bot pushed a commit that referenced this pull request May 1, 2020
@tfx-copybara
Fixes unintentional dependencies overriding in KFP container entrypoint.
d52862f 
After #1699 we're always using an ephemeral package that encodes the TFX dependency when running on Dataflow, so this additional argument is no longer needed in KFP entrypoint.

Closes #1696

PiperOrigin-RevId: 309082184
copybara-service bot pushed a commit that referenced this pull request May 1, 2020
@tfx-copybara
Fixes unintentional dependencies overriding in KFP container entrypoint.
99c4ee9 
After #1699 we're always using an ephemeral package that encodes the TFX dependency when running on Dataflow, so this additional argument is no longer needed in KFP entrypoint.

Closes #1696

PiperOrigin-RevId: 309082184
copybara-service bot pushed a commit that referenced this pull request May 1, 2020
@tfx-copybara
Fixes unintentional dependencies overriding in KFP container entrypoint.
4f5586a 
After #1699 we're always using an ephemeral package that encodes the TFX dependency when running on Dataflow, so this additional argument is no longer needed in KFP entrypoint.

Closes #1696

PiperOrigin-RevId: 309493107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tfx-copybara @googlebot