Add pre-commit lint action #6894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pre-commit lint action. Since there are lots of linting issues when running
ruff, this actions only runs linting on the changed files in the PR, until we fix all the linting issues.In future we can also directly use: https://pre-commit.ci/ which would also auto-commit linting issues. I didn't went with it right away as I couldn't find a way to do a selective run on the changed files with that.
The proposal is to get this in and start linting pull requests and slowly fix linting errors and then start running pre-commit on full code based instead of PR diff.