Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

Additional BERT/ALBERT examples #70

Merged
merged 6 commits into from
Nov 22, 2020

Conversation

hanneshapke
Copy link
Contributor

Two additional notebooks explaining:

  • the export of the BERT model using raw input data during deployment
  • the use of ALBERT instead of BERT for even easier deployments (smaller model size, faster inferences)

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@tcmetzger
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@rcrowe-google rcrowe-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest replacing this:

try:
    # %tensorflow_version only exists in Colab.
    %tensorflow_version 2.x
except Exception:
    pass

with this:

try:
  import colab
  !pip install --upgrade pip
except:
  pass

@hanneshapke
Copy link
Contributor Author

@rcrowe-google Very similar to #69 The notebooks are updated now with the requested change, increased the TFX version to 0.25, and updated the BERT/ALBERT version and model data structure. If it is ok with you, let's merge the updates or close the PR. Thank you for your review.

@rcrowe-google rcrowe-google merged commit e63e608 into tensorflow:master Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants