Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in_channels must equal to previous n_filter #1078

Closed
wants to merge 3 commits into from
Closed

in_channels must equal to previous n_filter #1078

wants to merge 3 commits into from

Conversation

tiancheng2000
Copy link
Contributor

@tiancheng2000 tiancheng2000 commented May 7, 2020 •
edited
Loading

Checklist

  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've tested that my changes are compatible with the latest version of Tensorflow.

Motivation and Context

Simple modification for rubustness of code. Otherwise all n_filters configured in a same layer_group must keep same, which is not neccessary.
Tested.

Description

Simple modification. Please refer to the diff.

@zsdonghao
Copy link
Member

please update the changelog and make the travis pass

@tiancheng2000
Copy link
Contributor Author

Travis-CI is complaining about RNN test failure, after I modified changelog?...

=========================== short test summary info ============================
FAILED tests/layers/test_layers_recurrent.py::Layer_RNN_Test::test_basic_simplernn_dropout_1
============ 1 failed, 229 passed, 10 warnings in 347.14s (0:05:47) ============

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsdonghao zsdonghao zsdonghao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiancheng2000 @zsdonghao