Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle] Update index.html and pyramid png #573

Merged
merged 4 commits into from
Sep 28, 2024

Conversation

HydrogenSulfate
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate commented Sep 4, 2024

  1. Add paddle url in index.html(It seems the source file of tensorly homepage)
  2. Add Paddle logo in pyramid png, and remove mxnet logo(related to Remove MXNet from doc #547, @JeanKossaifi , Remove mxnet #533 )

I found the homepage of tensorly is out of date and not consistent with index.html, will it be rebuild @aarmey ?

Copy link
Contributor

@aarmey aarmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @HydrogenSulfate. @JeanKossaifi, I think I'll need your help to identify why the website is not updating.

doc/index.html Outdated
<li> Pure Python, Tested & Optimized </li>
<li> Flexible Backends for:
<a target="_blank" href="https://numpy.org/"> NumPy</a>,
<a target="_blank" href="https://pytorch.org/"> PyTorch</a>,
<a target="_blank" href="https://www.tensorflow.org/"> TensorFlow</a>,
<a target="_blank" href="https://jax.readthedocs.io/en/latest/"> JAX</a>,
and <a target="_blank" href="https://cupy.dev/"> CuPy </a> </li>
<a target="_blank" href="https://cupy.dev/"> CuPy </a>,
and <a target="_blank" href="https://www.paddlepaddle.org.cn/en/install/quick?docurl=/documentation/docs/en/develop/install/pip/linux-pip_en.html"> PaddlePaddle</a> </li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to https://www.paddlepaddle.org.cn to be consistent with the other tools?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@JeanKossaifi
Copy link
Member

Thanks @HydrogenSulfate,

How did you make the jpg? If you worked directly on the existing image the result most likely would be lower res?
If you link me to the Paddle logo, I can update the original pyramid.

We probably should add a page to highlight the support of the various backends - what do you think @aarmey .

Re. website, is it not building? It should be deployed each time there is a new push on main?
Are you maybe looking at the stable version?
The dev version gets updated until we make a new release (we should probably make one soon).

@HydrogenSulfate
Copy link
Contributor Author

HydrogenSulfate commented Sep 5, 2024

Thanks @HydrogenSulfate,

How did you make the jpg? If you worked directly on the existing image the result most likely would be lower res? If you link me to the Paddle logo, I can update the original pyramid.

We probably should add a page to highlight the support of the various backends - what do you think @aarmey .

Re. website, is it not building? It should be deployed each time there is a new push on main? Are you maybe looking at the stable version? The dev version gets updated until we make a new release (we should probably make one soon).

  1. First I save the png in https://tensorly.org/stable/index.html, than I replace mxnet logo with a rectangle with same color as background and finally put Paddle logo. Here is the logo pic:
    飞桨英文标识RGB, you can use this logo in your original pyramid, thanks.

  2. I found the stable version of tensorly homepage is displayed in searching result, so MXNet is still here.
    image

image

and I couldn't find a switch where I can change the homepage version fron stable to dev

@aarmey
Copy link
Contributor

aarmey commented Sep 5, 2024

@JeanKossaifi you're right, the dev version is updated from my earlier changes. It looks like we just need to issue a new version.

@aarmey
Copy link
Contributor

aarmey commented Sep 28, 2024

Thanks @HydrogenSulfate!

@aarmey aarmey merged commit 51ab227 into tensorly:main Sep 28, 2024
8 checks passed
@HydrogenSulfate HydrogenSulfate deleted the update_README branch September 28, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants