chore: added synthetic generation error handling (#146)

commons/dataset/synthetic.py

@@ -11,6 +11,7 @@
     wait_exponential,
 )
 
+from commons.exceptions import SyntheticGenerationError
 from dojo.protocol import SyntheticQA
 
 SYNTHETIC_API_BASE_URL = os.getenv("SYNTHETIC_API_URL")
@@ -77,8 +78,18 @@ async def get_qa(cls) -> SyntheticQA | None:
                     async with cls._session.get(path) as response:
                         response.raise_for_status()
                         response_json = await response.json()
+                        if response_json["success"] is False:
+                            raise SyntheticGenerationError(
+                                message=response_json.get(
+                                    "error", "No error details provided"
+                                ),
+                            )
                         if "body" not in response_json:
-                            raise ValueError("Invalid response from the server.")
+                            raise SyntheticGenerationError(
+                                "Invalid response from the server. "
+                                "No body found in the response."
+                            )
+
                         synthetic_qa = _map_synthetic_response(response_json["body"])
                         logger.info("Synthetic QA generated and parsed successfully")
                         return synthetic_qa
@@ -88,5 +99,6 @@ async def get_qa(cls) -> SyntheticQA | None:
             )
             traceback.print_exc()
             raise
+
         except Exception:
             raise

commons/exceptions.py

@@ -76,3 +76,11 @@ class SetWeightsFailed(Exception):
     def __init__(self, message):
         self.message = message
         super().__init__(self.message)
+
+
+class SyntheticGenerationError(Exception):
+    """Raised when synthetic QA generation fails"""
+
+    def __init__(self, message: str):
+        self.message = message
+        super().__init__(self.message)

neurons/validator.py

@@ -27,6 +27,7 @@
     InvalidMinerResponse,
     NoNewExpiredTasksYet,
     SetWeightsFailed,
+    SyntheticGenerationError,
 )
 from commons.obfuscation.obfuscation_utils import obfuscate_html_and_js
 from commons.objects import ObjectManager
@@ -868,7 +869,12 @@ async def _generate_synthetic_request(
 
             return synapse, data.ground_truth, obfuscated_model_to_model
 
-        except (RetryError, ValueError, aiohttp.ClientError) as e:
+        except (
+            RetryError,
+            ValueError,
+            aiohttp.ClientError,
+            SyntheticGenerationError,
+        ) as e:
             logger.error(
                 f"Failed to generate synthetic request: {type(e).__name__}: {str(e)}"
             )