Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove embedding dataformat cast in tvm #1112

Closed
pmarkovicTT opened this issue Jan 27, 2025 · 0 comments · Fixed by #1111
Closed

Remove embedding dataformat cast in tvm #1112

pmarkovicTT opened this issue Jan 27, 2025 · 0 comments · Fixed by #1111
Assignees
@pmarkovicTT
Labels
difficulty/easy Easy Bounty

Comments

@pmarkovicTT
Copy link
Contributor

pmarkovicTT commented Jan 27, 2025 •
edited
Loading

We don't need explicit embedding dataformat cast in tvm (from float32 to bf16) as dataformat workaround for this case is implemented in mlir. PRs for reference:
@pmarkovicTT pmarkovicTT added the difficulty/easy Easy Bounty label Jan 27, 2025
@pmarkovicTT pmarkovicTT self-assigned this Jan 27, 2025
This was referenced Jan 27, 2025
Merged
Merged
pmarkovicTT added a commit to tenstorrent/tt-tvm that referenced this issue Jan 27, 2025
@pmarkovicTT
Revert embedding dataformat cast (#59)
705bca2 
We don't need explicit embedding dataformat cast in tvm (from float32 to
bf16) as dataformat workaround for this case is implemented in mlir.

PRs for reference:

- [TVM cast workaround](#55)
- [Embedding Op
workaround](tenstorrent/tt-mlir#1583)
- [EmbeddingBackward Op
workaround](tenstorrent/tt-mlir#1756)

Related to this issue
tenstorrent/tt-forge-fe#1112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmarkovicTT pmarkovicTT

Labels
difficulty/easy Easy Bounty
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove embedding dataformat cast in tvm and update llama backward test tenstorrent/tt-forge-fe
1 participant
@pmarkovicTT