Rewrote tests for scalars and dtypes. Wrote tests for ranks. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmitrovicTT
force-pushed
the
kmitrovic/fix_tests_for_dtypes_and_scalars
branch
2 times, most recently
from
83b2cb5 to
bacd7b4
Compare
kmitrovicTT
requested review from
ajakovljevicTT and
mrakitaTT
as code owners
1 task
kmitrovicTT
force-pushed
the
kmitrovic/fix_tests_for_dtypes_and_scalars
branch
from
bacd7b4 to
fa98957
Compare
|
||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 77.46% 78.24% +0.78%
==========================================
Files 21 21
Lines 1025 1025
==========================================
+ Hits 794 802 +8
+ Misses 231 223 -8 ☔ View full report in Codecov by Sentry. |
mrakitaTT
approved these changes
Jan 30, 2025
This was referenced Jan 30, 2025
mrakitaTT
approved these changes
Jan 31, 2025
kmitrovicTT
force-pushed
the
kmitrovic/fix_tests_for_dtypes_and_scalars
branch
4 times, most recently
from
2d7cc50 to
9050fab
Compare
kmitrovicTT
force-pushed
the
kmitrovic/fix_tests_for_dtypes_and_scalars
branch
from
9050fab to
41e0130
Compare
kmitrovicTT
commented
Feb 5, 2025
Comment on lines
-15
to
-17
| @pytest.mark.xfail( | ||
| reason="AssertionError: Atol comparison failed. Calculated: atol=0.804124116897583. Required: atol=0.16" | ||
| ) |
There was a problem hiding this comment.
This test unexpectedly passes now. @mrakitaTT
Same happened with test_simple_regression in #174
There was a problem hiding this comment.
The most reasonable explanation is what @sgligorijevicTT suggested that metal might have some non-determinism issues, but we should keep this on our radar and monitor if it happens again in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #135.