This repository has been archived by the owner on May 29, 2024. It is now read-only.
Correctly validate 'apps.misp.api.*' config settings #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2021 14:07
The 'apps.misp.api' key is optional, but the code used to assume that if it is present, then all three of the subkeys 'api.host', 'api.ssl' and 'api.key' are also present. We now validate that this is indeed the case.
lava
force-pushed
the
story/ch27771/misp-api-config
branch
from
0c58e1a
to
53b7867
Compare
|
This pull request introduces 1 alert when merging 53b7867 into aa34f53 - view on LGTM.com new alerts:
|
lava
force-pushed
the
story/ch27771/misp-api-config
branch
from
490cea2
to
53b7867
Compare
rolandpeelen
approved these changes
Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The 'apps.misp.api' key is optional, but the code used to assume
that if it is present, then all three of the subkeys 'api.host',
'api.ssl' and 'api.key' are also present.
We now validate that this is indeed the case.
📝 Checklist
🎯 Review Instructions
Try providing an invalid MISP config and verify that threatbus doesn't start and doesn't crash with an unhandled exception.