fix!: drop +closure preset (#1040)

teppeis · Sep 14, 2023 · aaecfc3 · aaecfc3
1 parent 8eebd54
commit aaecfc3
Show file tree

Hide file tree

Showing 16 changed files with 0 additions and 207 deletions.
diff --git a/+closure.js b/+closure.js
diff --git a/README.md b/README.md
@@ -21,14 +21,6 @@ Only additional or orverwritten rules are specified.
 
 ### Install
 
-#### for npm v6
-
-```console
-$ npm i -D eslint-config-teppeis eslint prettier
-```
-
-#### for npm v7+
-
 ```console
 $ npm i -D eslint-config-teppeis
 ```
@@ -154,16 +146,6 @@ This adds `browser` to `env`.
 }
 ```
 
-### For Closure Compiler coding style
-
-Extends `teppeis/+closure` after base config.
-
-```json
-{
-  "extends": ["teppeis/es2015", "teppeis/+closure"]
-}
-```
-
 ### Use Mocha for testing
 
 This enables mocha globals like `describe` or `it` in `**/test/*.js`.

diff --git a/examples/closure-es2015/.eslintrc.json b/examples/closure-es2015/.eslintrc.json
diff --git a/examples/closure-es2015/.prettierrc.json b/examples/closure-es2015/.prettierrc.json
diff --git a/examples/closure-es2015/index.js b/examples/closure-es2015/index.js
diff --git a/examples/closure/.eslintrc.json b/examples/closure/.eslintrc.json
diff --git a/examples/closure/.prettierrc.json b/examples/closure/.prettierrc.json
diff --git a/examples/closure/index.js b/examples/closure/index.js
diff --git a/lib/base.js b/lib/base.js
@@ -168,8 +168,6 @@ module.exports = {
     "jsdoc/require-hyphen-before-param-description": [2, "never"],
     "jsdoc/require-param-name": 2,
     "jsdoc/require-returns-check": 2,
-    // incompatible with closure style @extend
-    // maybe fixed in https://github.com/gajus/eslint-plugin-jsdoc/issues/305
     "jsdoc/valid-types": 2,
   },
   settings: {

diff --git a/lib/closure.js b/lib/closure.js
diff --git a/test/fixtures/.closure.eslintrc.json b/test/fixtures/.closure.eslintrc.json
diff --git a/test/fixtures/closure.dot-location.pass.js b/test/fixtures/closure.dot-location.pass.js
diff --git a/test/fixtures/closure.id-match.fail.js b/test/fixtures/closure.id-match.fail.js
diff --git a/test/fixtures/closure.id-match.pass.js b/test/fixtures/closure.id-match.pass.js
diff --git a/test/fixtures/es5+closure.jsdoc#check-tag-names.pass.js b/test/fixtures/es5+closure.jsdoc#check-tag-names.pass.js
diff --git a/test/index.js b/test/index.js
@@ -44,7 +44,6 @@ describe("eslint-config-teppeis", () => {
   describeVerify("es2016", true);
   describeVerify("es2017", true);
   describeVerify("es2019", true);
-  describeVerify("es5+closure", false, "fixtures/.closure.eslintrc.json");
   // describeVerify("+prettier", false, "fixtures/.prettier.eslintrc.json");
   describeVerify("typescript", true, "fixtures/.typescript.eslintrc.json");
   describeVerify("typescript-with-type", true, "fixtures/.typescript-with-type.eslintrc.json");