Support All file formats and pass file config in temp file #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the travis build is failing, all tests pass for me. Edit: So the travis build appears to be failing because the tests don't properly allow for the asyncronous nature of this module. The tests require that the child processes get executes in a specific order, which there is no gaurentee they will. I've raised #12 for this |
|
Thank you for pull-req. I'll check later. |
| @@ -65,7 +101,8 @@ function testGruntfile(name, callback) { | |||
| return; | |||
| } | |||
| try { | |||
| expect(stdout).to.be(expected); | |||
| expect(stdout.split('\n').sort().join('\n')) | |||
| .to.be(expected.split('\n').sort().join('\n')); | |||
There was a problem hiding this comment.
This change could pass failure result. but ok, I'll fix it later.
teppeis
added a commit
that referenced
this pull request
Mar 28, 2015
Support All file formats and pass file config in temp file
|
@Graham42 thanks! |
This was referenced Mar 28, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grunt tasks can have different file config formats according to the grunt Configuring tasks guide. This will add support for all file formats:
This fixes Unable to run with either traceur or react #7 and Unable to write "undefined" file #8
To simplify this work I first modified the way file config is passed to the child process. It is now passed in a temporary file which should address large configurations and fix #4