Merge pull request #18 from memory/default-deactivate

Default build activations to false
terabyte · Nov 17, 2015 · 4ba6ea9 · 4ba6ea9
2 parents 33f6e95 + 5f603f3
commit 4ba6ea9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/main/java/com/palantir/stash/stashbot/config/ConfigurationPersistenceImpl.java b/src/main/java/com/palantir/stash/stashbot/config/ConfigurationPersistenceImpl.java
@@ -211,10 +211,10 @@ public RepositoryConfiguration getRepositoryConfigurationForRepository(
                 RepositoryConfiguration.class,
                 new DBParam("REPO_ID", repo.getId()));
             rc.save();
-            // default the 3 base job types to enabled
-            setJobTypeStatusMapping(rc, JobType.VERIFY_COMMIT, true);
-            setJobTypeStatusMapping(rc, JobType.VERIFY_PR, true);
-            setJobTypeStatusMapping(rc, JobType.PUBLISH, true);
+            // default the 3 base job types to disabled
+            setJobTypeStatusMapping(rc, JobType.VERIFY_COMMIT, false);
+            setJobTypeStatusMapping(rc, JobType.VERIFY_PR, false);
+            setJobTypeStatusMapping(rc, JobType.PUBLISH, false);
             return rc;
         }
         return repos[0];

diff --git a/src/main/java/com/palantir/stash/stashbot/persistence/JobTypeStatusMapping.java b/src/main/java/com/palantir/stash/stashbot/persistence/JobTypeStatusMapping.java
@@ -39,7 +39,9 @@ public interface JobTypeStatusMapping extends Entity {
 
     @Accessor("IS_ENABLED")
     @NotNull
-    @Default("true")
+    // not actually honored on automatically vivified objects; see
+    // com.palantir.stash.stashbot.config.ConfigurationPersistenceImpl.RepositoryConfiguration
+    @Default("false")
     public Boolean getIsEnabled();
 
     @Mutator("IS_ENABLED")