@ #493 | should validate plugin params before proceeding #494
Conversation
ghost
assigned 
|
@hoatle I checked every case, and now the plugin configuration will work properly. |
lib/teracy-dev/plugin.rb
Outdated
| reload_required = true | ||
| name_validate = validate(plugin, 'name' => plugin['name']) | ||
| if !name_validate | ||
| logger.warn("Plugin name must be configured, not nil, and not empty") |
There was a problem hiding this comment.
"Plugin name must be configured"
lib/teracy-dev/plugin.rb
Outdated
| if installed_plugins.empty? | ||
| source_validate = validate(plugin, 'sources' => plugin['sources']) | ||
| if !source_validate | ||
| logger.warn("Plugin sources should be configured when no plugin installed, or we will use default") |
lib/teracy-dev/plugin.rb
Outdated
| reload_required = true | ||
| end | ||
| else | ||
| logger.debug('Plugin state not be set, do nothing') |
There was a problem hiding this comment.
when plugin.enabled is true and state is not setted, we should fill it with installed state
There was a problem hiding this comment.
plugin state is not set, then do nothing is expected. It means that if the plugin is installed or not installed, users don't care.
There was a problem hiding this comment.
okey, by the way, the message should be "The plugin state is not set, no action will be taken."
hieptranquoc
force-pushed
the
bug/#493-should-validate-plugin-params-before-proceeding
branch
from
2b98cd7
to
c556f84
Compare
|
@datphan I've updated! please check again. |
hieptranquoc
force-pushed
the
bug/#493-should-validate-plugin-params-before-proceeding
branch
from
c556f84
to
7ff558d
Compare
hieptranquoc
force-pushed
the
bug/#493-should-validate-plugin-params-before-proceeding
branch
from
7ff558d
to
8a28422
Compare
lib/teracy-dev/plugin.rb
Outdated
| @@ -45,5 +58,33 @@ def self.sync(plugins) | |||
| def self.installed?(plugin_name) | |||
| return Vagrant.has_plugin?(plugin_name) | |||
| end | |||
|
|
|||
| def self.validate(plugin, config) | |||
There was a problem hiding this comment.
don't introduce this type of complexity, as I can see it just checks the existence. So use Util.exist? instead
lib/teracy-dev/plugin.rb
Outdated
| plugin_manager.install_plugin(plugin['name'], Util.symbolize(plugin)) | ||
| reload_required = true | ||
| name_validate = validate(plugin, 'name' => plugin['name']) | ||
| if !name_validate |
There was a problem hiding this comment.
unless Util.exist? plugin['name'] is enough for example
hieptranquoc
force-pushed
the
bug/#493-should-validate-plugin-params-before-proceeding
branch
from
8a28422
to
fc1d021
Compare
|
@hoatle I've updated! please review again! |
hieptranquoc
deleted the
bug/#493-should-validate-plugin-params-before-proceeding
branch
connect #493
please review this PR!