This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Support multiple stations and Home Assistant MQTT Discovery #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added setting for polling interval since no point in having the interval at < 1 minute since Netatmo Weather station only sends updates every few minutes.
…ublishing configs for each attribute.
…eeded since it's handled by Netatmo lib automatically.
|
This pull request introduces 1 alert and fixes 2 when merging dadcac8 into cc33e37 - view on LGTM.com new alerts:
fixed alerts:
|
… will automatically pickup these values again on restart. Add mosquitto to docker-compose for simpler debugging since mosquitto requires some config to work with docker. Fixed status topic so it's consistent and uses same config setting.
…nstance loading passwords from a file, retaining messages and storing data in a local folder. Ignore docker-compose related files from docker build.
… config. Data might be missing when module out of battery?
|
@diversit This looks wonderful, sorry for missing this for so long! I updated dependences in this PR. If it's ready to go, let me know, happy to merge this! |
|
This pull request introduces 1 alert and fixes 2 when merging 445f9dd into a5211b2 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this nice project.
I used to extend it a bit so it has option support for Home Assistant MQTT Discovery. This means, when the. feature is enabled, the bridge automatically publishes configuration for each data entity to a topic so Home Assistant automatically can discover new data entities.
I also added support for multiple stations by adding the station name to the topic on which the data is published. Note: this is a breaking change if your setup expects a different topic structure.
Hereby I wish to contribute back to your project.
For you the choice whether to accept it or not.
Cheers, Joost