Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans up procedure tests and fixes unclean connection teardowns #54

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Cleans up procedure tests and fixes unclean connection teardowns #54

merged 1 commit into from
Mar 21, 2024

Conversation

StrongestNumber9
Copy link
Contributor

Some general cleanup for tests and closes connections so it should no longer print errors like this in mariadb logs

2024-03-21 11:28:37 2444 [Warning] Aborted connection 2444 to db: 'unconnected' user: 'testuser' host: 'localhost' (Got an error reading communication packets)
2024-03-21 11:28:37 2450 [Warning] Aborted connection 2450 to db: 'unconnected' user: 'testuser' host: 'localhost' (Got an error reading communication packets)
2024-03-21 11:28:37 2454 [Warning] Aborted connection 2454 to db: 'unconnected' user: 'testuser' host: 'localhost' (Got an error reading communication packets)
2024-03-21 11:28:37 2452 [Warning] Aborted connection 2452 to db: 'unconnected' user: 'testuser' host: 'localhost' (Got an error reading communication packets)

Nefarious46
Nefarious46 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@Nefarious46 Nefarious46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, straightforward changes.

@StrongestNumber9 StrongestNumber9 merged commit 4c4b1a9 into teragrep:main Mar 21, 2024
1 check passed
@StrongestNumber9 StrongestNumber9 deleted the fix_procedure_tests branch March 21, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nefarious46 Nefarious46 Nefarious46 approved these changes

@kortemik kortemik Awaiting requested review from kortemik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StrongestNumber9 @Nefarious46