-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement capture meta #68
Conversation
src/main/resources/db/migration/R__Procedure_Retrieve_Capture_meta.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retain capture_id instead of removing both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinions about the code, some notes about tests
src/test/java/com/teragrep/cfe18/controllerTests/CaptureMetaControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/teragrep/cfe18/controllerTests/CaptureMetaControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/teragrep/cfe18/controllerTests/CaptureMetaControllerTest.java
Show resolved
Hide resolved
src/test/java/com/teragrep/cfe18/controllerTests/CaptureMetaControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/teragrep/cfe18/controllerTests/CaptureMetaControllerTest.java
Outdated
Show resolved
Hide resolved
added 3 more commits for GET ALL and DELETE endpoints. |
src/main/java/com/teragrep/cfe18/handlers/CaptureMetaController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/cfe18/handlers/CaptureMetaController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/cfe18/handlers/CaptureMetaController.java
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/R__Procedure_add_capture_meta.sql
Outdated
Show resolved
Hide resolved
Can be reviewed again since requested changes are made. |
No description provided.