Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement capture meta #68

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Conversation

Nefarious46
Copy link
Contributor

No description provided.

@Nefarious46 Nefarious46 requested review from StrongestNumber9 and kortemik and removed request for StrongestNumber9 June 13, 2024 09:38
@Nefarious46 Nefarious46 self-assigned this Jun 13, 2024
@Nefarious46 Nefarious46 added the feature Existing feature label Jun 13, 2024
Copy link
Member

@kortemik kortemik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retain capture_id instead of removing both

Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions about the code, some notes about tests

@Nefarious46
Copy link
Contributor Author

added 3 more commits for GET ALL and DELETE endpoints.

@Nefarious46
Copy link
Contributor Author

Can be reviewed again since requested changes are made.

@kortemik kortemik merged commit edf191d into teragrep:main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants