Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test: Change from Base64 to Hex encoding #22

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Fix failing test: Change from Base64 to Hex encoding #22

merged 5 commits into from
Jun 5, 2024

Conversation

eemhu
Copy link
Contributor

@eemhu eemhu commented Jun 4, 2024

Fixes the failing test by changing Base64 to Hex encoding, as the KeyStore implementation does not guarantee case sensitivity for aliases.

Also includes:

  • Added tests
  • Close all Input/OutputStreams
  • DecodedHex object
  • Invalidates cache on credential delete

eemhu added 4 commits May 30, 2024 13:09
@eemhu
close all streams, change AddEntryTest to use a second KeyStoreAccess…
5d12c4d 
… instead.
@eemhu
use expireAfterWrite; set secs=0 in tests
1b3dfd9
@eemhu
switch back to refreshAfterWrite for cache, use 1 sec delay in tests;…
87d22fc 
… invalidate verify cache on credential delete; switch Salt from Base64 encoding to Hex encoding as KeyStore aliases are always lowercase (no guarantees of case sensitivity)
@eemhu
rename test (remove underscore)
85703a6
StrongestNumber9
StrongestNumber9 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me assuming that the two comments are not action worthy

src/main/java/com/teragrep/jai_02/password/DecodedHex.java Show resolved Hide resolved
src/test/java/com/teragrep/jai_02/tests/KeyStoreAccessImplTest.java Outdated Show resolved Hide resolved
StrongestNumber9
StrongestNumber9 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StrongestNumber9 StrongestNumber9 merged commit dd7cda2 into teragrep:main Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StrongestNumber9 StrongestNumber9 StrongestNumber9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eemhu @StrongestNumber9