Adds k8s01 prefix to collected app-specific metrics (#92)

* Adds k8s_01 prefix to collected app-specific metrics * Remove underscore from metrics prefix * Remove underscore from metrics prefix#2
teragrep · Aug 2, 2023 · 48a9b56 · 48a9b56
1 parent ab36f8d
commit 48a9b56
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/main/java/com/teragrep/k8s_01/PrometheusMetrics.java b/src/main/java/com/teragrep/k8s_01/PrometheusMetrics.java
@@ -50,14 +50,15 @@ public PrometheusMetrics(int port) {
         ServletHolder servletHolder = new ServletHolder(metricsServlet);
         context.addServlet(servletHolder, "/metrics");
 
+        // TODO: Prefix to be configurable?
         // Totals
-        metricRegistry.register(name("total", "reconnects"), new Counter());
-        metricRegistry.register(name("total", "connections"), new Counter());
+        metricRegistry.register(name("k8s01", "total", "reconnects"), new Counter());
+        metricRegistry.register(name("k8s01", "total", "connections"), new Counter());
 
         // Throughput meters
-        metricRegistry.register(name("throughput", "bytes"), new Meter(new SlidingTimeWindowMovingAverages()));
-        metricRegistry.register(name("throughput", "records"), new Meter(new SlidingTimeWindowMovingAverages()));
-        metricRegistry.register(name("throughput", "errors"), new Meter(new SlidingTimeWindowMovingAverages()));
+        metricRegistry.register(name("k8s01", "throughput", "bytes"), new Meter(new SlidingTimeWindowMovingAverages()));
+        metricRegistry.register(name("k8s01", "throughput", "records"), new Meter(new SlidingTimeWindowMovingAverages()));
+        metricRegistry.register(name("k8s01", "throughput", "errors"), new Meter(new SlidingTimeWindowMovingAverages()));
 
         // Misc
         metricRegistry.register(name("jvm", "vm"), new JvmAttributeGaugeSet());

diff --git a/src/main/java/com/teragrep/k8s_01/RelpOutput.java b/src/main/java/com/teragrep/k8s_01/RelpOutput.java
@@ -63,13 +63,13 @@ public class RelpOutput {
         relpConnection.setReadTimeout(relpConfig.getReadTimeout());
         relpConnection.setWriteTimeout(relpConfig.getWriteTimeout());
         // Throughput
-        throughputBytes = metricRegistry.meter(name("throughput", "bytes"));
-        throughputRecords = metricRegistry.meter(name("throughput", "records"));
-        throughputErrors = metricRegistry.meter(name("throughput", "errors"));
+        throughputBytes = metricRegistry.meter(name("k8s01", "throughput", "bytes"));
+        throughputRecords = metricRegistry.meter(name("k8s01", "throughput", "records"));
+        throughputErrors = metricRegistry.meter(name("k8s01", "throughput", "errors"));
 
         // Totals
-        totalConnections = metricRegistry.counter(name("total", "connections"));
-        totalReconnects = metricRegistry.counter(name("total", "reconnects"));
+        totalConnections = metricRegistry.counter(name("k8s01", "total", "connections"));
+        totalReconnects = metricRegistry.counter(name("k8s01", "total", "reconnects"));
         connect();
     }