Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception handling for bloom option json reading #370

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add exception handling for bloom option json reading #370

wants to merge 7 commits into from

Conversation

elliVM
Copy link
Contributor

@elliVM elliVM commented Oct 9, 2024 •
edited
Loading

  • Catch exceptions thrown by gson when reading filter fields option string to JSON
  • Use FilterField object to store filter field options expected and fpp and test
  • Get BloomFilter bitSize from FilterField object
  • Add tests for incorrect JSON fromat in options and duplicate filter field values

@elliVM elliVM self-assigned this Oct 9, 2024
@elliVM elliVM added the bug Something isn't working label Oct 9, 2024
@elliVM elliVM changed the title Add exception handling for json reading Add exception handling for bloom option json reading Oct 10, 2024
51-code
51-code requested changes Oct 10, 2024
View reviewed changes
Copy link

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes.

src/main/java/com/teragrep/pth10/steps/teragrep/TeragrepBloomStep.java Outdated Show resolved Hide resolved
src/main/java/com/teragrep/pth10/steps/teragrep/TeragrepBloomStep.java Show resolved Hide resolved
src/main/java/com/teragrep/pth10/steps/teragrep/bloomfilter/FilterField.java Outdated Show resolved Hide resolved
src/main/java/com/teragrep/pth10/steps/teragrep/bloomfilter/FilterTypes.java Outdated Show resolved Hide resolved
src/main/java/com/teragrep/pth10/steps/teragrep/bloomfilter/FilterTypes.java Outdated Show resolved Hide resolved
@elliVM
create FilterTypes and LazyConnect in TeragrepBloomStep constructor, …
91649b8 
…catch correct exception types from gson.fromJson(), FilterField class final
@elliVM elliVM requested a review from 51-code October 10, 2024 09:31
51-code
51-code approved these changes Oct 10, 2024
View reviewed changes
Copy link

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now with the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@51-code 51-code 51-code approved these changes

@kortemik kortemik Awaiting requested review from kortemik

Assignees

@elliVM elliVM

Labels
bug Something isn't working review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elliVM @51-code @ronja-ui