-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move table and regex option to dpl #414
Open
elliVM
wants to merge
9
commits into
teragrep:main
Choose a base branch
from
elliVM:bloom-options-dpl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51-code
requested changes
Nov 18, 2024
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/TeragrepTransformation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth10/steps/teragrep/bloomfilter/JournalDBNameFromConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/pth10/steps/teragrep/bloomfilter/FilterTypes.java
Outdated
Show resolved
Hide resolved
src/test/java/com/teragrep/pth10/steps/teragrep/bloomfilter/BloomFilterTableTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/teragrep/pth10/steps/teragrep/bloomfilter/BloomFilterTableTest.java
Show resolved
Hide resolved
src/test/java/com/teragrep/pth10/steps/teragrep/bloomfilter/FilterTypesTest.java
Show resolved
Hide resolved
src/test/java/com/teragrep/pth10/steps/teragrep/bloomfilter/TeragrepBloomFilterTest.java
Show resolved
Hide resolved
elliVM
force-pushed
the
bloom-options-dpl
branch
from
November 19, 2024 06:22
b367976
to
0cff473
Compare
51-code
requested changes
Nov 20, 2024
src/main/java/com/teragrep/pth10/ast/commands/transformstatement/teragrep/ContextValue.java
Outdated
Show resolved
Hide resolved
.../teragrep/pth10/ast/commands/transformstatement/teragrep/EstimateColumnFromBloomContext.java
Outdated
Show resolved
Hide resolved
.../com/teragrep/pth10/ast/commands/transformstatement/teragrep/RegexValueFromBloomContext.java
Outdated
Show resolved
Hide resolved
...a/com/teragrep/pth10/ast/commands/transformstatement/teragrep/TableNameFromBloomContext.java
Outdated
Show resolved
Hide resolved
51-code
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eemhu
reviewed
Nov 20, 2024
src/main/java/com/teragrep/pth10/steps/teragrep/bloomfilter/TableSQL.java
Outdated
Show resolved
Hide resolved
eemhu
reviewed
Nov 20, 2024
src/main/java/com/teragrep/pth10/steps/teragrep/bloomfilter/BloomFilterTable.java
Outdated
Show resolved
Hide resolved
eemhu
reviewed
Nov 20, 2024
src/test/java/com/teragrep/pth10/steps/teragrep/bloomfilter/BloomFilterTableTest.java
Outdated
Show resolved
Hide resolved
eemhu
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM. I think the ContextValue seems like a good idea.
…m bloom filter table, secondary constructor for Pattern.compile
eemhu
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Support for
teragrep exec bloom create/update
to get spark configuration optionsdpl.pth_06.bloom.pattern
anddpl.pth_06.bloom.table.name
from dpl.Example dpl after change
| teragrep exec bloom create table 'table_name' regex '\w{8}' estimates 'R_estimate(tokens)' input 'tokens'
Changes
tableName()
, journalDBname()
andpattern()
from FilterTypes object