Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RelpParser tests #51

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Conversation

StrongestNumber9
Copy link
Contributor

No description provided.

@StrongestNumber9 StrongestNumber9 linked an issue Aug 22, 2023 that may be closed by this pull request
@StrongestNumber9 StrongestNumber9 linked an issue Aug 22, 2023 that may be closed by this pull request
@StrongestNumber9 StrongestNumber9 changed the title Adds RelpParser tests, removes getState() from RelpParser Adds RelpParser tests Aug 23, 2023
src/test/java/com/teragrep/rlp_01/RelpParserTest.java Outdated Show resolved Hide resolved

@Test
public void testMultipleLastNewlines() {
RelpParser parser = createParser("0 rsp 3 six\n\n\n\n\n\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be illegal

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec says only on \n is after the message, however the \n\n\n is considered next message because six is only 3 bytes long

@StrongestNumber9 StrongestNumber9 merged commit 862c451 into teragrep:master Aug 23, 2023
@StrongestNumber9 StrongestNumber9 deleted the test_parser branch August 23, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test relp parser
2 participants