Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement workaround for https://github.com/marianobarrios/tls-channe… #66

Merged
merged 3 commits into from
May 28, 2024
Merged

implement workaround for https://github.com/marianobarrios/tls-channe… #66

merged 3 commits into from
May 28, 2024

Conversation

kortemik
Copy link
Member

…l/issues/233

@kortemik
Copy link
Member Author

kortemik commented May 28, 2024 •
edited
Loading

closes #65

@kortemik kortemik linked an issue May 28, 2024 that may be closed by this pull request
tls reading gets stuck if rx buffer is smaller than server send buffer #65
Closed
@kortemik kortemik self-assigned this May 28, 2024
@kortemik kortemik requested review from eemhu and removed request for 51-code May 28, 2024 08:37
StrongestNumber9
StrongestNumber9 requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, sockets are not my strong suit but Exception messages could be clarified

src/main/java/com/teragrep/rlp_01/RelpClientTlsSocket.java Outdated Show resolved Hide resolved
src/main/java/com/teragrep/rlp_01/RelpClientTlsSocket.java Outdated Show resolved Hide resolved
src/main/java/com/teragrep/rlp_01/RelpClientTlsSocket.java Outdated Show resolved Hide resolved
StrongestNumber9
StrongestNumber9 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay

eemhu
eemhu approved these changes May 28, 2024
View reviewed changes
Copy link

@eemhu eemhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kortemik kortemik merged commit 28c246f into teragrep:master May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StrongestNumber9 StrongestNumber9 StrongestNumber9 approved these changes

@eemhu eemhu eemhu approved these changes

Assignees

@kortemik kortemik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tls reading gets stuck if rx buffer is smaller than server send buffer
3 participants
@kortemik @StrongestNumber9 @eemhu