reordering the packets

[spidermanja]

When Responses comes in the different order from the java-relp-server, this might need to sort and reorganize the packets for proper flow control.
find the attachment for anomalies

[kortemik]

Hi, TCP might re-order the packages but that is ok because network layer will correct the order and the application does not see tcp level order but only the order that the packets were sent with. Relp also accepts re-ording of responses from the server to the client but that's different thing but still possible. I checked the java-relp-server code and it should sent everything in the order that the requests were received.

…

On Mon, Nov 14, 2022 at 3:00 PM spidermanja ***@***.***> wrote: When Responses comes in the different order from the java-relp-server, this might need to sort and reorganize the packets for proper flow control. find the attachment for anomalies [image: rlp_2closeanomalies1] <https://user-images.githubusercontent.com/93120208/201666353-191b3ba7-2316-4078-b5cd-082906a17a9d.png> — Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGX2OXHSQNPEFEFA3B63FDWIIZVDANCNFSM6AAAAAAR7ZRG3U> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[spidermanja]

Handling closeResponse for null currently fix the issue.
However, potential security related issue

• Packet with invalid error status possibly generate NULL deference.
  Possible vulnerability, A NULL pointer dereference might occur when the application dereferences a pointer that it expects to be valid, but is NULL, typically causing a crash or exit.

[kortemik]

Hi, Would it be possible to check if it is NULL before accessing it and initialize the get method to return empty string in case it is null? Kind regards, Mikko

…

On Tue, Dec 13, 2022 at 12:00 PM spidermanja ***@***.***> wrote: Handling closeResponse for null currently fix the issue. However, potential security related issue - Packet with invalid error status possibly generate NULL deference. Possible vulnerability, A NULL pointer dereference might occur when the application dereferences a pointer that it expects to be valid, but is NULL, typically causing a crash or exit. — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGX2OS4NMSGGA4CMBDP4ZTWNBCNBANCNFSM6AAAAAAR7ZRG3U> . You are receiving this because you commented.Message ID: ***@***.***>

[spidermanja]

Yes, adjusted on this commit 3e50537
but without returning any string.
Seems no more complains now👍