close clientDelegate in case connectContextFactory.create throws (#126)

teragrep · Apr 9, 2024 · 328c023 · 328c023
1 parent 8123988
commit 328c023
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/main/java/com/teragrep/rlp_03/client/ClientDelegate.java b/src/main/java/com/teragrep/rlp_03/client/ClientDelegate.java
@@ -104,7 +104,7 @@ public boolean accept(FrameContext frameContext) {
     }
 
     @Override
-    public void close() throws Exception {
+    public void close() {
         LOGGER.debug("client FrameDelegate close");
     }
 

diff --git a/src/main/java/com/teragrep/rlp_03/client/ClientFactory.java b/src/main/java/com/teragrep/rlp_03/client/ClientFactory.java
@@ -73,8 +73,16 @@ public Client open(InetSocketAddress inetSocketAddress)
         Consumer<EstablishedContext> establishedContextConsumer = readyContextFuture::complete;
 
         ClientDelegate clientDelegate = new ClientDelegate();
-        ConnectContext connectContext = connectContextFactory
-                .create(inetSocketAddress, clientDelegate, establishedContextConsumer);
+
+        ConnectContext connectContext;
+        try {
+            connectContext = connectContextFactory
+                    .create(inetSocketAddress, clientDelegate, establishedContextConsumer);
+        }
+        catch (IOException ioException) {
+            clientDelegate.close();
+            throw ioException;
+        }
         LOGGER.debug("registering to eventLoop <{}>", eventLoop);
         eventLoop.register(connectContext);
         LOGGER.debug("registered to eventLoop <{}>", eventLoop);