implement workaround for EstablishedContextStub being closed (#210)

teragrep · Jun 25, 2024 · 5ec838a · 5ec838a
1 parent 99ca9e6
commit 5ec838a
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 2 deletions.
diff --git a/src/main/java/com/teragrep/net_01/channel/context/EstablishedContext.java b/src/main/java/com/teragrep/net_01/channel/context/EstablishedContext.java
@@ -74,4 +74,6 @@ public interface EstablishedContext extends Context {
      * @return Egress of the connection for sending egress data.
      */
     Egress egress();
+
+    boolean isStub();
 }
diff --git a/src/main/java/com/teragrep/net_01/channel/context/EstablishedContextImpl.java b/src/main/java/com/teragrep/net_01/channel/context/EstablishedContextImpl.java
@@ -252,4 +252,10 @@ public Ingress ingress() {
     public Egress egress() {
         return egress;
     }
+
+    @Override
+    public boolean isStub() {
+        return false;
+    }
+
 }
diff --git a/src/main/java/com/teragrep/net_01/channel/context/EstablishedContextStub.java b/src/main/java/com/teragrep/net_01/channel/context/EstablishedContextStub.java
@@ -98,4 +98,10 @@ public Ingress ingress() {
     public Egress egress() {
         throw new IllegalArgumentException("EstablishedContextStub does not implement this");
     }
+
+    @Override
+    public boolean isStub() {
+        return true;
+    }
+
 }
diff --git a/src/main/java/com/teragrep/net_01/eventloop/EventLoop.java b/src/main/java/com/teragrep/net_01/eventloop/EventLoop.java
@@ -149,13 +149,17 @@ else if (selectionKey.isConnectable()) {
                         establishedContext.handleEvent(selectionKey);
                     }
                     catch (CancelledKeyException cke) {
-                        establishedContext.close();
+                        if (!establishedContext.isStub()) {
+                            establishedContext.close();
+                        }
                         throw cke;
+
                     }
                 }
             }
             catch (CancelledKeyException cke) {
-                LOGGER.warn("SocketPoll.poll CancelledKeyException caught: <{}>", cke.getMessage());
+                // TODO implement better exception handling in ConnectContext, ListenContext and EstablishedContext
+                LOGGER.warn("Detected unexpectedly closed channel");
             }
         }
 

diff --git a/src/test/java/com/teragrep/net_01/channel/context/EstablishedContextFake.java b/src/test/java/com/teragrep/net_01/channel/context/EstablishedContextFake.java
@@ -104,4 +104,10 @@ public Ingress ingress() {
     public Egress egress() {
         return egress;
     }
+
+    @Override
+    public boolean isStub() {
+        return false;
+    }
+
 }