setup signing in a separate step so cleanup works (#182)

teragrep · May 16, 2024 · a9f3c83 · a9f3c83
1 parent b103aa4
commit a9f3c83
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/.github/workflows/upload_release.yaml b/.github/workflows/upload_release.yaml
@@ -2,7 +2,7 @@ name: Upload Release
 
 on:
   release:
-    types: published
+    types: [published]
 
 jobs:
   upload:
@@ -18,15 +18,20 @@ jobs:
           path: ~/.m2/repository
           key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
 
-      - name: Setup GitHub Packages
+      - name: Setup Signing
         uses: actions/setup-java@v2
         with:
           java-version: 8.0.292+10
           distribution: 'adopt'
-
           gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }}
           gpg-passphrase: MAVEN_GPG_PASSPHRASE
 
+      - name: Setup GitHub Packages
+        uses: actions/setup-java@v2
+        with:
+          java-version: 8.0.292+10
+          distribution: 'adopt'
+
       - name: Publish to GitHub Packages
         run: mvn --batch-mode -Drevision=${{ github.event.release.tag_name }} -Dsha1= -Dchangelist= clean deploy -Ppublish-github-packages
         env:
@@ -44,13 +49,10 @@ jobs:
           server-username: CENTRAL_SONATYPE_ORG_USERNAME
           server-password: CENTRAL_SONATYPE_ORG_PASSWORD
 
-          gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }}
-          gpg-passphrase: MAVEN_GPG_PASSPHRASE
-
       - name: Publish to Maven Central
         run: mvn --batch-mode -Drevision=${{ github.event.release.tag_name }} -Dsha1= -Dchangelist= clean deploy -Ppublish-maven-central
         env:
           CENTRAL_SONATYPE_ORG_USERNAME: ${{ secrets.CENTRAL_SONATYPE_ORG_USERNAME }}
           CENTRAL_SONATYPE_ORG_PASSWORD: ${{ secrets.CENTRAL_SONATYPE_ORG_PASSWORD }}
           MAVEN_GPG_PASSPHRASE: ${{ secrets.MAVEN_GPG_PASSPHRASE }}
-          
+