Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate possibility to use a Phaser instead of a custom solution in Access and BufferLeaseImpl #61

Closed
kortemik opened this issue Feb 16, 2024 · 2 comments · Fixed by #84
Closed

investigate possibility to use a Phaser instead of a custom solution in Access and BufferLeaseImpl #61

kortemik opened this issue Feb 16, 2024 · 2 comments · Fixed by #84
Assignees
@eemhu

Comments

@kortemik
Copy link
Member

rlp_03/src/main/java/com/teragrep/rlp_03/context/frame/access/Access.java

Line 13 in 60da329

this.accessCount = 0; // TODO consider using a semaphore

https://github.com/teragrep/rlp_03/blob/main/src/main/java/com/teragrep/rlp_03/context/buffer/BufferLeaseImpl.java#L14
@kortemik kortemik changed the title investigate possibility to use a semaphore instead of a custom solution in Access and BufferLeaseImpl investigate possibility to use a Phaser instead of a custom solution in Access and BufferLeaseImpl Feb 19, 2024
@kortemik
Copy link
Member Author

code comment states Semaphore but Java has a better structure that could be used which is Phaser.

@kortemik
Copy link
Member Author

https://stackoverflow.com/questions/14255019/latch-that-can-be-incremented

@eemhu eemhu mentioned this issue Feb 20, 2024
Closed
@kortemik kortemik linked a pull request Mar 6, 2024 that will close this issue
Issue 61 Fix with old style "Access" instead of "Rental" #84
Merged
kortemik added a commit that referenced this issue Mar 6, 2024
@eemhu @kortemik
Implement BufferLease using Phaser
7d5c9ba 
Implement BufferLease using Phaser for #61 

---------

Co-authored-by: Mikko Kortelainen <1@teragrep.com>
@kortemik kortemik mentioned this issue Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eemhu eemhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 61 Fix with old style "Access" instead of "Rental" eemhu/rlp_03
2 participants
@kortemik @eemhu