Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move FragmentClock out from FragmentImpl #187

Merged
merged 2 commits into from
May 21, 2024

Conversation

kortemik
Copy link
Member

No description provided.

@kortemik kortemik requested a review from eemhu May 20, 2024 13:15
Copy link
Contributor

@eemhu eemhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, small notes but approved

txn = fragmentStub;
command = fragmentStub;
payloadLength = fragmentStub;
cachedPayloadLength = Integer.MIN_VALUE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally at -2^31?

@kortemik kortemik merged commit c3f22cf into teragrep:main May 21, 2024
1 check passed
@kortemik kortemik deleted the fragment-clock branch May 21, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants