Mongo #5
Merged
Mongo #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bill828 could you help to review? |
bill828
reviewed
Jul 1, 2020
pkg/store/mongodb/mongodbStore.go
Outdated
| } | ||
| var services []pms.Service | ||
| if err = cur.All(ctx, &services); err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Why panic here? panic may terminate the process. Is that possible to return the error?
bill828
requested changes
Jul 1, 2020
| filter := bson.D{{"_id", serviceName}} | ||
| update := bson.D{{"$pull", bson.D{{"policies", bson.D{{"$exists", true}}}}}} | ||
| result := serviceCollection.FindOneAndUpdate(ctx, filter, update) | ||
| if result.Err() == mongo.ErrNoDocuments { |
There was a problem hiding this comment.
I believe the segment should be:
if result.Err() != nil {
if result.Err() == mongo.ErrNoDocuments {
return errors.Errorf(xxxxx)
}
return result.Err()
}
return nil
There was a problem hiding this comment.
It seems no need to check if result.Err() != nil here.
pkg/store/mongodb/mongodbStore.go
Outdated
| } | ||
| var services []pms.Service | ||
| if err = cur.All(ctx, &services); err != nil { | ||
| panic(err) |
| (counts["service1"].RolePolicyCount != int64(len(rolePolicies))) { | ||
| t.Fatal("incorrect role policy number") | ||
| } | ||
| fmt.Println(counts) |
pkg/store/mongodb/storeBuiler.go
Outdated
| import ( | ||
| "context" | ||
|
|
||
| "github.com/prometheus/common/log" |
There was a problem hiding this comment.
We are using logrus, not prometheus log.
pkg/store/mongodb/storeBuiler.go
Outdated
| client, err := mongo.Connect(context.TODO(), clientOptions) | ||
|
|
||
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
Does log.Fatal terminate the process?
There was a problem hiding this comment.
yes, will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.