Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move s3 asset storage related fields to teraslice section of config #3601

Closed
busma13 opened this issue May 1, 2024 · 1 comment
Closed

move s3 asset storage related fields to teraslice section of config #3601

busma13 opened this issue May 1, 2024 · 1 comment
Assignees
@sotojn

Comments

@busma13
Copy link
Contributor

busma13 commented May 1, 2024

When the external asset storage feature was implemented, all the fields in the config were put in the terafoundation section, but they are specific to teraslice so should be in that section.

To move them to teraslice we need to move the validation function. Unfortunately it requires access to terafoundation.connectors so the inputs to validator functions will need to allow for the whole config to be passed in.
@godber
Copy link
Member

godber commented May 9, 2024

Lets deprecate the asset_storage_* keys in terafoundation. at the same time as adding them to teraslice. That way we're not making a breaking change to the terafoundation.yml. Also make sure to add comments that allow us to find and remove the asset_storage keys that need to be removed in 2.0.

@busma13 busma13 assigned busma13 and sotojn and unassigned sotojn and busma13 May 14, 2024
@sotojn sotojn mentioned this issue May 17, 2024
Merged
godber added a commit that referenced this issue May 17, 2024
@sotojn @godber
Move s3 asset_storage settings to teraslice config (#3614)
718ec56 
This PR makes the following changes:

- **\*\*Deprecated\*\*** all `asset_storage` configuration settings in
terafoundation
- These configuration settings now live in the teraslice config and will
be removed from terafoundation in teraslice 2.0
- The teraslice `asset_storage` config settings will take priority of
the terafoundation `asset_storage` settings if both are set.
- Updated documentation with information on deprecation.
- Bumps the following packages:
  - (patch) **@terascope/job-components** to `v0.74.2`
  - (patch) **@terascope/types** to `v0.17.2`
  - (patch) **@terascope/data-mate** to `v0.56.2` 
  - (patch) **elasticsearch-store** to `v0.84.2`
  - (patch)  **ts-transforms** to `v0.85.2`
  - (patch) **xlucene-parser** to `v0.58.2` 
  - (patch) **xlucene-translator** to `v0.44.2`
  - (patch) **@terascope/elasticsearch-api** to `v3.20.2` 
  - (patch) **@terascope/teraslice-state-storage** to `v0.53.2`
  - (minor) **terafoundation** to `v0.64.0`
- Bumps **teraslice** to from `v1.5.1` to `v1.6.0`

Ref to issue #3601

---------

Co-authored-by: Austin Godber <godber@terascope.io>
@godber godber closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@godber @busma13 @sotojn