Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript version - 5.5 or 5.6 #3772

Open
busma13 opened this issue Sep 25, 2024 · 3 comments
Open

Update typescript version - 5.5 or 5.6 #3772

busma13 opened this issue Sep 25, 2024 · 3 comments
Assignees
@busma13

Comments

@busma13
Copy link
Contributor

busma13 commented Sep 25, 2024

Currently we are using typescript 5.2.2. The latest version is 5.6.2.

It would be nice to get completely caught up.
We could then update typedoc which is blocked due to typescript version (#3768)
@busma13 busma13 self-assigned this Sep 25, 2024
@godber godber changed the title Update typescript version Update typescript version - 5.5 or 5.6 Sep 25, 2024
@busma13
Copy link
Contributor Author

busma13 commented Oct 7, 2024

In 5.5 the suppressImplicitAnyIndexErrors rule will be removed. That means we have to properly type any object[key] style call. We can turn off the rule in each package's tsconfig and then fix the errors in that package only, making the PRs smaller. Keeping that rule around until it can be removed from the root tsconfig will prevent any new code from introducing more errors of this type.

@busma13 busma13 mentioned this issue Oct 7, 2024
Merged
godber pushed a commit that referenced this issue Oct 17, 2024
@busma13
[job-components, scripts, terafoundation, teraslice-cli, teraslice-cl…
09febc5 
…ient-js, teraslice-messaging, utils, xlucene-parser] fix implicit any index typescript errors (#3789)

In typescript 5.5 the `suppressImplicitAnyIndexErrors` rule will be
removed. This PR fixes all ignored errors of this type in the following
packages in preparation for the move to version 5.5 or above:
- job-components
- scripts
- terafoundation
- teraslice-cli
- teraslice-client-js
- teraslice-messaging
- utils
- xlucene-parser

`suppressImplicitAnyIndexErrors` is set to true in the tsconfig of all
updated packages so we don't introduce any more of these errors before
the rule is removed at the root level.

Todo: bump packages

Packages that still have these errors:
- data-mate - 1
- elasticsearch-store - 22
- teraslice - 124
- teraslice-state-storage - 13
- ts-transforms - 20

ref: #3772
@godber
Copy link
Member

godber commented Dec 18, 2024

Is there an MR for this?

@busma13
Copy link
Contributor Author

busma13 commented Dec 18, 2024

Not yet.

@busma13 busma13 mentioned this issue Dec 19, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busma13 busma13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@godber @busma13