port in use errors in CI

[busma13]

We keep getting port in use errors.
I would like to try using ss to list all ports in TIME_WAIT to see if they are not being shut down fast enough.

The other option is to assign random ports.

Example failures:
https://github.com/terascope/teraslice/actions/runs/11981509936/job/33407933870

● Test suite failed to run

    listen EADDRINUSE: address already in use :::55678

      140 |             await new Promise((resolve, reject) => {
      141 |                 // @ts-expect-error
    > 142 |                 this.app.listen(this.port, (err: Error) => {
          |                          ^
      143 |                     if (err) {
      144 |                         reject(err);
      145 |                         return;

      at Function.apply [as listen] (node_modules/express/lib/application.js:635:24)
      at listen (packages/teraslice/src/lib/cluster/services/assets.ts:142:26)
      at AssetsService.initialize (packages/teraslice/src/lib/cluster/services/assets.ts:140:19)
      at Object.<anonymous> (packages/teraslice/test/services/assets-spec.ts:67:9)

https://github.com/terascope/teraslice/actions/runs/11941437795/job/33286764202

docker: Error response from daemon: driver failed programming external connectivity on endpoint ts_test_kafka (fb60d1c2428b6a3ad031693a716c1897da234a8e33577b500cd45bd8242830ae): Error starting userland proxy: listen tcp4 0.0.0.0:49092: bind: address already in use.

[busma13]

I have found port related errors in 3 different spots:

• assets service tests
• teraslice messaging server
• docker run of service images

These 3 different areas may need to be handled separately.

[busma13]

The teraslice package has a findPort() function that some of the tests use. It returns a random open port. I am adding this to assets-spec.ts, which should resolve the first list item in my previous comment.

[busma13]

https://github.com/terascope/teraslice/actions/runs/11921771709/job/33226709312

This failure uses the findPort() function. I am guessing multiple tests run this function at the same time and there end up being collisions. We use porty to test if the port is open, but it looks like we start at the same port for all these tests and move up until porty says one is open. Maybe 2 tests get assigned the same open port at the same time.

[busma13]

findPort() allows you to set a port range, so I am giving each test a unique range to prevent collisions.

[godber]

Have there been fewer or zero port errors on tests after this was merged?

[godber]

Or has the added netstat command helped narrow trouble down.

[busma13]

There haven't been too many CI runs, but no port errors yet.