Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jobs.list in teraslice-client-js and remove jobs method #880

Closed
godber opened this issue Nov 1, 2018 · 0 comments
Closed

Fix Jobs.list in teraslice-client-js and remove jobs method #880

godber opened this issue Nov 1, 2018 · 0 comments

Comments

@godber
Copy link
Member

godber commented Nov 1, 2018

Jobs.list shouldn't return executions:

https://github.com/terascope/teraslice/blob/v0.43.0/packages/teraslice-client-js/lib/jobs.js#L30-L33

and the jobs() method should be removed:

https://github.com/terascope/teraslice/blob/v0.43.0/packages/teraslice-client-js/lib/jobs.js#L35-L38

Earl should be updated to use .list() after this is fixed and we should look to see if we're using Jobs.list() and see if we're really expecting exes somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant