Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli asset fix #3566

Merged
merged 9 commits into from
Mar 15, 2024
Merged

Cli asset fix #3566

merged 9 commits into from
Mar 15, 2024

Conversation

jsnoble
Copy link
Member

@jsnoble jsnoble commented Mar 12, 2024

  • fixes the require bug when building assets

Copy link
Member

@ciorg ciorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit dcb854b into master Mar 15, 2024
41 checks passed
@jsnoble jsnoble deleted the cli-asset-fix branch March 15, 2024 16:59
godber pushed a commit that referenced this pull request Apr 11, 2024
When e2e tests download the latest version of default assets to
autoload, the `deleteOlderAssets` function would run. The node version
was not being checked, resulting in all duplicate assets with the same
version being erased, regardless of node version.

This function will now delete all autoload files that do not match the
teraslice node version before checking for older asset versions.

Ref: #3566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants