Refactor PromMetrics to use Collect functions #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
changed the title
busma13
changed the title
godber
approved these changes
May 9, 2024
| @@ -326,6 +314,7 @@ export class WorkerExecutionContext | |||
| } | |||
|
|
|||
| async onSliceFinished(): Promise<void> { | |||
| this.slicesFinished++; | |||
There was a problem hiding this comment.
I guess this will max out at 9quadrillion. We have jobs completing 2 million slices a day. I guess a job would have to run 4.5 billion days to hit that. Should be fine.
> Number.MAX_SAFE_INTEGER/2_000_000
4503599627.370496
| logger: Logger, | ||
| ) { | ||
| this.context = context; | ||
| this.name = name; |
There was a problem hiding this comment.
I am happy to see the removal of a context object passed in ...
| name: string, | ||
| help: string, | ||
| labelsNames: Array<string>, | ||
| type: 'gauge' | 'counter' | 'histogram', | ||
| buckets: Array<number> = [0.1, 5, 15, 50, 100, 500] |
There was a problem hiding this comment.
In hindsight, the presence of this optional buckets argument should have been a clue that addMetric was too ambitious.
|
I would like to merge this but I would like @jsnoble to double check some of the lower level type changes. I think he's seen these recently but I didn't want to merge without an OK from him. |
bump: (minor) @terascope/job-components@0.74.0, terafoundation@0.63.0 bump: (minor) @terascope/types@0.17.0, @terascope/utils@0.59.0 bump: (minor) @terascope/data-types@0.50.0, @terascope/data-mate@0.56.0 bump: (minor) elasticsearch-store@0.84.0, ts-transforms@0.85.0 bump: (minor) xlucene-parser@0.58.0, xlucene-translator@0.44.0 bump: (minor) @terascope/elasticsearch-api@3.20.0, @terascope/teraslice-state-storage@0.53.0
busma13
force-pushed
the
collect-functions-prom-metrics
branch
from
563ff48 to
4871320
Compare
godber
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
addMetricinto individual functions for counter, gauge, and histogram.collect()parameter to alladd<metric>functions.prom-clienttypes intotypespackageterafoundationandjob-componentsand import fromtypes. This required some refactoring to not use context as a parameter, as thecontexttype differs betweenterafoundationandjob-components.infometrics of slice, worker, and master into thesetPromMetrics()functions.