mark running jobs as failed on exc k8s restart #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
changed the title
busma13
force-pushed
the
mark-job-failed-on-k8s-exc-restart
branch
from
ecca23e to
7c83155
Compare
godber
approved these changes
Jun 14, 2024
busma13
added a commit
that referenced
this pull request
Jun 18, 2024
This PR makes the following changes:
- The `ExecutionController` `_verifyExecution()` function now marks the
execution status as failed if the current status is a `running` status
('recovering', 'running', 'failing', 'paused', 'stopping'). We can't
start from a running state so the job will be stopped, but we were not
updating the status previously. The assumption is that one of these
statuses means that the execution controller pod has crashed and k8s is
restarting a new pod. We would never get in this situation in native
clustering, as there are check before the execution controller process
is forked.
- The `ExecutionService` `_finishExecution()` function also marks the
execution status as failed if in a `running` status. It looks like this
function is designed to run after an execution controller error and
shutdown, so it's safe to assume a running status means there was an
error and the execution controller shut down before status was updated.
Ref: #2673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
ExecutionController_verifyExecution()function now marks the execution status as failed if the current status is arunningstatus ('recovering', 'running', 'failing', 'paused', 'stopping'). We can't start from a running state so the job will be stopped, but we were not updating the status previously. The assumption is that one of these statuses means that the execution controller pod has crashed and k8s is restarting a new pod. We would never get in this situation in native clustering, as there are check before the execution controller process is forked.ExecutionService_finishExecution()function also marks the execution status as failed if in arunningstatus. It looks like this function is designed to run after an execution controller error and shutdown, so it's safe to assume a running status means there was an error and the execution controller shut down before status was updated.Ref: #2673