Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci, scripts] Remove duplicate unused unit tests in CI #3866

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[ci, scripts] Remove duplicate unused unit tests in CI #3866

merged 3 commits into from
Dec 10, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Dec 10, 2024 •
edited
Loading

This PR makes the following changes:

  • Migrates all unit tests from unit-esm back to unit
  • Removes linux-unit-esm-tests from ci
    • This is no longer needed because all tests have been migrated to linux-unit-tests

Ref to issue #3858

@sotojn sotojn self-assigned this Dec 10, 2024
@sotojn
Copy link
Contributor Author

sotojn commented Dec 10, 2024

I have validated that all the tests have been migrated correctly. I compared this PRs linux-unit-tests (22) with linux-unit-esm-tests (22) and they are identical.

@sotojn sotojn marked this pull request as ready for review December 10, 2024 21:22
@sotojn sotojn requested review from busma13, jsnoble and godber December 10, 2024 21:23
@godber godber merged commit c0a6aeb into master Dec 10, 2024
46 checks passed
@godber godber deleted the ci-unit-tests-cleanup branch December 10, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

@busma13 busma13 Awaiting requested review from busma13

@jsnoble jsnoble Awaiting requested review from jsnoble

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sotojn @godber