Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issues after yarn 4 update #3896

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Fix CI issues after yarn 4 update #3896

merged 3 commits into from
Jan 9, 2025

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Jan 9, 2025 •
edited
Loading

This PR makes the following changes:

  • Fixes broken ci piplines that publish npm packages after a merge to master
    • This is caused by scripts using the old yarn 1 sub-command to publish npm packages which yarn 4 doesn't support
  • bump: (minor) @terascope/scripts@1.9.0

@sotojn sotojn self-assigned this Jan 9, 2025
@sotojn sotojn requested review from godber and busma13 January 9, 2025 23:25
busma13
busma13 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sotojn sotojn merged commit 1332f86 into master Jan 9, 2025
46 checks passed
@sotojn sotojn deleted the fix-npm-publish branch January 9, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busma13 busma13 busma13 approved these changes

@godber godber Awaiting requested review from godber

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sotojn @busma13