Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using DataSourceTransactionManager may be committed on error of commit phase #259

Closed
2 tasks done
bturamatuyu opened this issue Jan 26, 2017 · 0 comments
Closed
2 tasks done

Comments

@bturamatuyu
Copy link
Contributor

bturamatuyu commented Jan 26, 2017

Description

If an error occurs during the commit phase if DataSourceTransactionManager is used in the default state,
There is a possibility that it will be committed.

Possible Solutions

add <property name="rollbackOnCommitFailure" value="true" />
in terasoluna-gfw-web-blank/infra/common/META-INF/spring/projectName-env.xml

...
    <bean id="transactionManager"
        class="org.springframework.jdbc.datasource.DataSourceTransactionManager">
        <property name="dataSource" ref="dataSource" />
    </bean>
...

...
    <bean id="transactionManager"
        class="org.springframework.jdbc.datasource.DataSourceTransactionManager">
        <property name="dataSource" ref="dataSource" />
        <property name="rollbackOnCommitFailure" value="true" />
    </bean>
...

Affects Version/s

  • 5.X.X.RELEASE
  • 1.X.X.RELEASE

Fix Version/s

  • 5.3.0
  • 5.2.1

Issue Links

@bturamatuyu bturamatuyu self-assigned this Jan 26, 2017
@bturamatuyu bturamatuyu modified the milestones: 2017 summer, 2017 winter Jan 26, 2017
@bturamatuyu bturamatuyu changed the title DataSourceTransactionManagerを使うとCommitフェーズのエラー時にCommitされる可能性がある Using DataSourceTransactionManager may be committed on error of commit phase Jan 26, 2017
bturamatuyu added a commit that referenced this issue Jan 26, 2017
bturamatuyu added a commit that referenced this issue Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants