Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scope of taglibs-standard-jstlel has been omitted #295

Closed
2 tasks done
kazuki43zoo opened this issue Sep 8, 2017 · 0 comments
Closed
2 tasks done

scope of taglibs-standard-jstlel has been omitted #295

kazuki43zoo opened this issue Sep 8, 2017 · 0 comments
Labels
action: backport action: migration-guide type: improvement version: 5.7.0
Milestone
5.7.0.M2

Comments

@kazuki43zoo
Copy link
Contributor

kazuki43zoo commented Sep 8, 2017 •
edited by btkobayashirun
Loading

Description

Normally, I think JSTL need only at runtime time.
Therefore I prefer it specify the runtime scope.

Current definition: (=compile scope is specified implicitly)

terasoluna-gfw-web-blank/pom.xml

Lines 177 to 180 in fbb32ae

<dependency>
<groupId>org.apache.taglibs</groupId>
<artifactId>taglibs-standard-jstlel</artifactId>
</dependency>

Possible Solutions

Modify as follow:

<dependency> 
     <groupId>org.apache.taglibs</groupId> 
     <artifactId>taglibs-standard-jstlel</artifactId> 
+     <scope>runtime</scope>
 </dependency>

What do you think?

Affects Version/s

  • 5.X.X.RELEASE
  • 1.X.X.RELEASE

Fix repositories

  • terasoluna-gfw-web-blank
  • m-j
  • [ ] m-t

Issue Links

  • #XXX
@hirakuriy hirakuriy added this to the Oct. Rv1 milestone Jun 14, 2018
@hirakuriy hirakuriy removed this from the Oct. Rv1 milestone Dec 5, 2018
@btkatoufm btkatoufm added this to the 5.7.0.M2 milestone Sep 24, 2020
btonokit added a commit that referenced this issue Oct 16, 2020
@btonokit
set test scope in jstlel #295
850c28b
btonokit added a commit that referenced this issue Oct 16, 2020
@btonokit
set runtime scope in jstlel #295
c5685ff
@btonokit btonokit mentioned this issue Oct 16, 2020
Merged
btkobayashirun added a commit that referenced this issue Oct 16, 2020
@btkobayashirun
Merge pull request #447 from terasolunaorg/issues/295_set_the_scope_o…
186bacf 
…f_jstlel

set runtime scope in taglibs-standard-jstlel #295
@btonokit btonokit mentioned this issue Oct 20, 2020
Closed
2 tasks
@btonokit btonokit mentioned this issue Oct 22, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
action: backport action: migration-guide type: improvement version: 5.7.0
Projects
None yet
Milestone
5.7.0.M2
Development

No branches or pull requests
6 participants
@kazuki43zoo @yoshikawaa @itouyun @btkobayashirun @hirakuriy @btkatoufm