Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change configuration value of 'onError' option of sql-maven-plugin. (continue -> abort) #193

Closed
1 task done
kazuki43zoo opened this issue Nov 27, 2015 · 0 comments
Closed
1 task done

Change configuration value of 'onError' option of sql-maven-plugin. (continue -> abort) #193

kazuki43zoo opened this issue Nov 27, 2015 · 0 comments
Assignees
@btshimizukza
Labels
type: improvement
Milestone
5.1.0

Comments

@kazuki43zoo
Copy link
Contributor

Description

Currently, onError option is continue.
If continue is specified, we can not detect sql errors(mistakes of DDL and DML) on maven build.
As a reslt, there are possible to occur a unexpected error on integration tests.

Possible Solutions

Change from continue to abort.
abort is default value on onError option of sql-maven-plugin.

Affects Version/s

  • 5.0.0.RELEASE - 5.0.1.RELASE
  • 1.0.0.RELEASE - 1.0.3.RELEASE

Fix Version/s

  • 5.1.0

Issue Links

N/A
@kazuki43zoo kazuki43zoo added this to the 5.1.0 milestone Nov 27, 2015
kazuki43zoo added a commit that referenced this issue Nov 27, 2015
@kazuki43zoo
Change configuration value of 'onError' option of sql-maven-plugin. (…
4b811fc 
…continue -> abort) #193
kazuki43zoo added a commit that referenced this issue Nov 27, 2015
@kazuki43zoo
Change configuration value of 'onError' option of sql-maven-plugin. (…
0de1f16 
…continue -> abort) #193
This was referenced Nov 27, 2015
Merged
Closed
Closed
making added a commit that referenced this issue Nov 29, 2015
@making
Merge pull request #194 from terasolunaorg/issues/193_change-onError-…
38c5421 
…of-sql-maven-plugin

Change configuration value of 'onError' option of sql-maven-plugin. (continue -> abort) #193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btshimizukza btshimizukza

Labels
type: improvement
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
2 participants
@kazuki43zoo @btshimizukza