Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the validator provided by terasoluna-gfw compliant with Bean Validation 2.0 #857

Closed
2 tasks done
btyanagawamg opened this issue Jan 18, 2019 · 1 comment
Closed
2 tasks done

Make the validator provided by terasoluna-gfw compliant with Bean Validation 2.0 #857

btyanagawamg opened this issue Jan 18, 2019 · 1 comment
Assignees
@btyanagawamg
Labels
type: new-feature version: 5.5.1
Milestone
5.5.1

Comments

@btyanagawamg
Copy link
Contributor

btyanagawamg commented Jan 18, 2019 •
edited by hirakuriy
Loading

related #858

Description

Make the validator provided by terasoluna-gfw compliant with Bean Validation 2.0 .

Specifically, we do as follows .

  • Add Type_USE to the @Target annotation attribute .
    (Support of container element constraints and cascaded validation)
  • Add @Repeatable(List.class) .
    (You can write multiple same annotations in the same place)

The target validator is as follows .

  • @ExistInCodeList
  • @ConsistOf
  • @ByteMax
  • @ByteMin

Possible Solutions

(Please write ideas or candidates of solutions for the problem if you have)

Affects Version/s

  • 5.X.X.RELEASE
  • 1.X.X.RELEASE

Fix Version/s

  • 5.5.1 (master)
  • 5.4.2 (5.4.x) : backport unify target of constraint annotations(improvement and Not compliant with Bean Validation 2.0)

Issue Links
@btyanagawamg btyanagawamg self-assigned this Jan 18, 2019
@btyanagawamg btyanagawamg added this to the 5.6.0.RELEASE milestone Jan 18, 2019
btyanagawamg added a commit that referenced this issue Jan 28, 2019
@btyanagawamg
apply Bean Validation 2.0 for validator provided by terasoluna-gfw #857
ab1c92e
@btyanagawamg btyanagawamg mentioned this issue Jan 28, 2019
Merged
btyanagawamg added a commit that referenced this issue Jan 28, 2019
@btyanagawamg
apply Bean Validation 2.0 for validator provided by terasoluna-gfw #857
40859b4
btyanagawamg added a commit that referenced this issue Jan 28, 2019
@btyanagawamg
remove un-need @Valid annotation #857
6f90aa4
btyanagawamg added a commit that referenced this issue Jan 29, 2019
@btyanagawamg
change to import static ElementType #857
1e28d6d
btyanagawamg added a commit that referenced this issue Jan 29, 2019
@btyanagawamg
not to use import java.lang.annotation.* #857
1eb99a5
btyanagawamg added a commit that referenced this issue Jan 29, 2019
@btyanagawamg
add ElementType.CONSTRUCTOR to @ConsistOf and @ExistInCodeList #857
fed13a2
btyanagawamg added a commit that referenced this issue Jan 29, 2019
@btyanagawamg
improvement @ConsistOf test case #857
5a10183
btyanagawamg added a commit that referenced this issue Jan 29, 2019
@btyanagawamg
make iterator creation only one time #857
5f389da
btyanagawamg added a commit that referenced this issue Jan 29, 2019
@btyanagawamg
change to use stream api #857
ecfe0a3
btyanagawamg added a commit that referenced this issue Jan 30, 2019
@btyanagawamg
fix naming conventions #857
e1265f4
btyanagawamg added a commit that referenced this issue Jan 31, 2019
@btyanagawamg
improvement test case of @ConsistOf #857
498f969
btyanagawamg added a commit that referenced this issue Jan 31, 2019
@btyanagawamg
fix naming conventions #857
178b8c3
btyanagawamg added a commit that referenced this issue Jan 31, 2019
@btyanagawamg
remove un-need cast #857
cc4a742
btyanagawamg added a commit that referenced this issue Jan 31, 2019
@btyanagawamg
remove un-need import #857
f554dbf
btyanagawamg added a commit that referenced this issue Jan 31, 2019
@btyanagawamg
remove un-need Throwable #857
9847a86
btyanagawamg added a commit that referenced this issue Feb 4, 2019
@btyanagawamg
remove un-need Throwable #857
988f4ab
yoshikawaa pushed a commit that referenced this issue Feb 4, 2019
@btyanagawamg @yoshikawaa
apply Bean Validation 2.0 for validator provided by terasoluna-gfw #857…
3d5fce0 
… (#863)

* apply Bean Validation 2.0 for validator provided by terasoluna-gfw #857

* remove un-need @Valid annotation #857

* change to import static ElementType #857

* not to use import java.lang.annotation.* #857

* add ElementType.CONSTRUCTOR to @ConsistOf and @ExistInCodeList #857

* improvement @ConsistOf test case #857

* make iterator creation only one time #857

* change to use stream api #857

* fix naming conventions #857

* improvement test case of @ConsistOf #857

* fix naming conventions #857

* remove un-need cast #857

* remove un-need import #857

* remove un-need Throwable #857

* remove un-need Throwable #857
btyanagawamg added a commit that referenced this issue Apr 4, 2019
@btyanagawamg
backport some improvement #857
af71e9f
@btyanagawamg
Copy link
Contributor Author

btyanagawamg commented Apr 4, 2019 •
edited
Loading

I Re-Open to backport unify target of constraint annotations(improvement and Not compliant with Bean Validation 2.0)
(5.4.x branch will not be compliant with Bean Validation 2.0)

@btyanagawamg btyanagawamg reopened this Apr 4, 2019
@btyanagawamg btyanagawamg mentioned this issue Apr 4, 2019
Merged
hirakuriy added a commit that referenced this issue Apr 4, 2019
@hirakuriy
Merge pull request #895 from terasolunaorg/issues/857_backport-some-i…
bf5d9b9 
…mprovement-5.4.x

[5.4.x] Unify target of constraint annotations #857
@btyanagawamg btyanagawamg mentioned this issue Apr 9, 2019
Closed
3 tasks
@yoshikawaa yoshikawaa mentioned this issue Oct 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btyanagawamg btyanagawamg

Labels
type: new-feature version: 5.5.1
Projects
None yet
Milestone
5.5.1
Development

No branches or pull requests
3 participants
@yoshikawaa @btyanagawamg @hirakuriy