ionic-native package

[arberkryeziu]

hi,

what was your exact workaround to include PhotoLibrary into ionic-native? I see that you included the package from your local filesystem "ionic-native": "file://e:/dev/github/viskin/ionic-native". Hence the demo app can not be build in someone elses computer

[arberkryeziu]

One more thing. Have you tested in any iOS ? I did test in emulator and its working fine, however on my iPhone, I cant show images. I think it is because the photos are synchronized in icloud, and just putting the photoURL into src of an img-element does not trigger loading of that photo from the icloud. What do you think ?

[viskin]

@ArberK You can wait until ionic-native approve the PR, and technically, you can clone https://github.com/viskin/ionic-native, and run 'npm run build' - this will create ionic-native package locally.
I should say that performance that I've got with ng2 is worth then that I've got with react. ionic's virtualScroll component seems still bugy and restrictive. Hope this will change.

[viskin]

@ArberK I will try this on iPhone.

[arberkryeziu]

@viskin is there a chance that you forgot to include LibraryItem in ionic-native ?

[viskin]

Unlikely, as I compiled the demo without errors with ionic-native. You can see it in ionic-native/src/plugins/photo-library.ts (if I remember it right)

…

On יום ה׳, 23 בפבר׳ 2017 at 13:28 arberK ***@***.***> wrote: @viskin <https://github.com/viskin> is there a chance that you forgot to include LibraryItem in ionic-native ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKYX9B5Z43aVLqn3rtU9zNPGfefm_Lplks5rfW1pgaJpZM4MJNoM> .

[arberkryeziu]

@ArberK I will try this on iPhone.

did you have time to try it?

[viskin]

@ArberK I tried the demo project on iPhone, and images do appear (both thumbnails and full).
I previously did permit cloud-based photos to appear, but due to complains about loading times removed it.
If you want, you can experiment with this row. Please tell if setting it to true is not slowing things down too much.