Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve list page table #181

Merged
merged 21 commits into from
Mar 12, 2024
Merged

Improve list page table #181

merged 21 commits into from
Mar 12, 2024

Conversation

wazolab
Copy link
Member

@wazolab wazolab commented Feb 28, 2024

  • Search place holder should be translated
  • The search field can be stylized ? Maybe like on on the map ? The selector and the filter fieldtowgeter are a bit confusing
  • Category change from selector is no more working
  • Column header should be translated
  • cuisine fields some time contains []
  • Opening hours days should de translated (maybe an other issue not linked to this PR ?) / But maybe disable de detail in the table view ?

@wazolab wazolab self-assigned this Feb 28, 2024
@wazolab wazolab linked an issue Feb 28, 2024 that may be closed by this pull request
6 tasks
@wazolab wazolab requested a review from frodrigo February 28, 2024 16:44
@frodrigo
Copy link
Member

frodrigo commented Feb 29, 2024

ping @sbterito

@wazolab wazolab force-pushed the 172-improve-list-page-table branch from ad6f539 to acd622b Compare February 29, 2024 16:04
components/Layout/Footer.vue Outdated Show resolved Hide resolved
@wazolab
Copy link
Member Author

wazolab commented Mar 1, 2024

Refactor

  • Create useContrib() composable for more reusability
  • Reduce component depth, remove PoisList / PoiLayout

UI improvements

  • Add search slot in Header component
  • Handle loading states
  • Add placeholder to DataTable search field

Todo

  • Adapt PoisTable story
  • Improve pois-list test

Can't do

  • Sorting by column (See Issue)

@frodrigo
Copy link
Member

frodrigo commented Mar 1, 2024

  • Could you move "chore: convert contrib to composable" to it own PR, and other unrelated changes to their own PR, please.
  • Q: losing the header will be bad for SEO, doesn't ?
  • About the header, I was thing we talk about the table header and not the page header.

@sbterito vvv
Screenshot 2024-03-01 at 11-44-31 Glaciers

@wazolab wazolab force-pushed the 172-improve-list-page-table branch 2 times, most recently from ba3c231 to 37cdf5e Compare March 4, 2024 11:14
@frodrigo
Copy link
Member

frodrigo commented Mar 4, 2024

Look like bad rebase, could you check, please ?

@wazolab wazolab force-pushed the 172-improve-list-page-table branch 3 times, most recently from 988f2c6 to 755362b Compare March 4, 2024 11:32
nuxt.config.ts Outdated Show resolved Hide resolved
@wazolab
Copy link
Member Author

wazolab commented Mar 5, 2024

Column header should be translated
It's already linked with PropertyTranslations but for the moment we only have French version. I kept the same behavior as before. Is this ok ?

@wazolab wazolab force-pushed the 172-improve-list-page-table branch from dff4dc4 to fba4b01 Compare March 5, 2024 09:19
@wazolab
Copy link
Member Author

wazolab commented Mar 5, 2024

cuisine fields some time contains []

After testing it with Bordeaux config, I can say that it's normal behavior, we display arrays in <ul> list, if array is empty we display a raw string.

@frodrigo: Maybe API shouldn't be allowed to send keys with empty Arrays ?

@wazolab wazolab force-pushed the 172-improve-list-page-table branch from 1cb0569 to c89e3dc Compare March 5, 2024 14:16
@wazolab wazolab force-pushed the 172-improve-list-page-table branch 2 times, most recently from e0e8288 to 129a2ad Compare March 7, 2024 12:42
pages/category/[id].vue Outdated Show resolved Hide resolved
pages/category/[id].vue Outdated Show resolved Hide resolved
@wazolab wazolab force-pushed the 172-improve-list-page-table branch from 129a2ad to 1f96e76 Compare March 7, 2024 17:27
@frodrigo frodrigo merged commit 6f60d4a into develop Mar 12, 2024
5 checks passed
wazolab added a commit that referenced this pull request Mar 12, 2024
wazolab added a commit that referenced this pull request Mar 12, 2024
@wazolab wazolab deleted the 172-improve-list-page-table branch April 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve list page table
2 participants