Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature mismatch for native method "crypto_generichash_blake2b_salt_personal()" #75

Closed
jcihocki opened this issue Jul 6, 2020 · 6 comments
Closed

Signature mismatch for native method "crypto_generichash_blake2b_salt_personal()" #75

jcihocki opened this issue Jul 6, 2020 · 6 comments
Assignees
@gurpreet-
Labels
bug You've found something that definitely should not happen, e.g a crash in a critical part of the lib enhancement New feature or request

Comments

@jcihocki
Copy link

jcihocki commented Jul 6, 2020

Created a PR here, if you're interested: https://github.com/jcihocki/lazysodium-java/pull/

native method declared in Sodium.java has subKeyId as long, native method expects unsigned char * for both salt and personal so it should be byte[]
@gurpreet- gurpreet- self-assigned this Jul 6, 2020
@gurpreet- gurpreet- added bug You've found something that definitely should not happen, e.g a crash in a critical part of the lib enhancement New feature or request labels Jul 6, 2020
gurpreet- added a commit that referenced this issue Jul 6, 2020
@gurpreet-
Change long to byte[] #75
b5de9ae
@gurpreet-
Copy link
Contributor

Hey nice spot, I have updated this and will be available in the next release!

@jcihocki
Copy link
Author

jcihocki commented Jul 6, 2020

Awesome, thank you!

@nathankurtyka
Copy link

@gurpreet- Hello! Any approximate timeline for the next release?

I only ask because we're considering migrating our production stack to LazySodium, and this issue might be a blocker.

@gurpreet-
Copy link
Contributor

@nathankurtyka Will release a new version today! It contains a minor breaking change in order to fix some scrypt related methods.

@gurpreet-
Copy link
Contributor

Fixed in release 4.3.0.

@gurpreet-
Copy link
Contributor

gurpreet- commented Jul 10, 2020 •
edited
Loading

I've migrated my CI infrastructure to AzureCI (#77) so now we also have the benefit of testing across platforms rather than just testing on Linux. Should be extra resilient to these failures.

Will update Lazysodium Android ASAP too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gurpreet- gurpreet-

Labels
bug You've found something that definitely should not happen, e.g a crash in a critical part of the lib enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcihocki @nathankurtyka @gurpreet-