Add Ristretto255 support #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Libsodium has Ristretto support now? 🙂 Reviewing now. |
gurpreet-
reviewed
Jul 3, 2021
src/main/java/com/goterl/lazysodium/interfaces/Ristretto255.java
Outdated
Show resolved
Hide resolved
src/main/java/com/goterl/lazysodium/interfaces/Ristretto255.java
Outdated
Show resolved
Hide resolved
src/main/java/com/goterl/lazysodium/interfaces/Ristretto255.java
Outdated
Show resolved
Hide resolved
|
Hey, sorry for the late reply, I've been having quite some busy days lately. I will address your suggested changes this week as soon as I have time 😄 |
|
Hi, any chance this will be merged and deployed any time soon? |
|
As @michielgkalkman says. @Traderjoe95 It would be great if this pull request could be completed. :) |
|
Hey all, sorry for the massive delay. I've been completely swamped at work lately, so I couldn't really continue working on this. But I guess I will be able to finish all those changes today. Let's see. |
|
@gurpreet- I addressed all your comments, I hope we are clear to merge now. 😃 Cheers! |
gurpreet-
approved these changes
May 2, 2022
|
Looks great! Merged! |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsodium is supporting the Ristretto255 prime order group. This PR implements support in LazySodium.